status/network: Use NM connectivity check URI for Portal Helper

NetworkManager can check if a network interface has "internet access" by
invoking a HTTP request.

The URI used for connectivity checking in NetworkManager can be configured
manually in NetworkManager.conf:

[connectivity]
uri=http://portal-check.exmaple.com/nm-check.txt

Portal Helper provides an argument to pass the URI that should be opened.
If this argument is empty it uses http://nmcheck.gnome.org as a fallback.

Pass the URI configured in NetworkManager to Portal Helper instead of
an empty string.

Fixes #1313

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2228>

diff --git a/js/ui/status/network.js b/js/ui/status/network.js
index aef2373fb85700c17921b1b484851242ae5be51c..7a191e03bd7d2c029f0b91a562758e47ce73e6da 100644 (file)
--- a/js/ui/status/network.js
+++ b/js/ui/status/network.js
@@ -2060,7 +2060,7 @@ class Indicator extends SystemIndicator {
             }
         }
 
-        this._portalHelperProxy?.AuthenticateAsync(path, '', timestamp).catch(logError);
+        this._portalHelperProxy?.AuthenticateAsync(path, this._client.connectivity_check_uri, timestamp).catch(logError);
 
         this._connectivityQueue.add(path);
     }